kredits/kredits-web
9
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Releases 18 Activity

Remove mentions of Ethereum from UI and code, refactor wallet connect #214

Merged
raucao merged 7 commits from chore/remove_last_ethereum_bits into master 2023-08-14 15:53:44 +00:00
Conversation 2 Commits 7 Files Changed 22
+338 -222
raucao commented 2023-01-20 09:30:21 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This removes all remaining mentions of Ethereum from both the UI and the source code, and also fixes and improves all known wallet/account connect issues.

Furthermore, it will ask the visitor to switch their connected wallet to RSK Testnet (in the app's production mode), or to add it as new custom network (using our own RSK node), and then switch, if the network ID is not available yet. Please note that this does not work properly with localhost networks in dev (at least it's broken in Metamask atm).

closes #150, #170, #215

This removes all remaining mentions of Ethereum from both the UI and the source code, and also fixes and improves all known wallet/account connect issues. Furthermore, it will ask the visitor to switch their connected wallet to RSK Testnet (in the app's production mode), or to add it as new custom network (using our own RSK node), and then switch, if the network ID is not available yet. Please note that this does not work properly with localhost networks in dev (at least it's broken in Metamask atm). closes #150, #170, #215
bumi (Migrated from github.com) reviewed 2023-01-20 09:30:21 +00:00
raucao commented 2023-02-02 04:28:20 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@bumi This PR is basically finished. However, signup is actually broken, because hal8000 is not allowed to create profiles anymore. I don't remember what our proposed solution for replacing the previous permission for it was.

@bumi This PR is basically finished. However, signup is actually broken, because hal8000 is not allowed to create profiles anymore. I don't remember what our proposed solution for replacing the previous permission for it was.
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#214
Delete Branch "chore/remove_last_ethereum_bits"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?