kredits/kredits-web
9
0
Fork 0
Code Issues 21 Pull Requests Actions Releases 19 Activity

[WIP] Update Ember to version 3.8.0 #88

Closed
galfert wants to merge 2 commits from feature/84-update_ember into master
pull from: feature/84-update_ember
merge into: :master
Conversation 6 Commits 2 Files Changed 16
+7606 -2198
galfert commented 2019-03-27 11:45:15 +00:00 (Migrated from github.com)
Copy Link
Copy Source

At the moment there is still a deprecation warning about ember-browserify left. There is no update for that library yet, and the maintainer recommends to switch to ember-auto-import instead. So far I couldn't get that to work with importing kredits-contracts though.

At the moment there is still a deprecation warning about ember-browserify left. There is no update for that library yet, and the maintainer recommends to switch to ember-auto-import instead. So far I couldn't get that to work with importing kredits-contracts though.
raucao (Migrated from github.com) reviewed 2019-03-27 15:03:19 +00:00
app/components/chart-contributions-by-type/component.js
@@ -15,0 +17,4 @@
init () {
this._super(...arguments);
this.set('chartOptions', {
raucao (Migrated from github.com) commented 2019-03-27 15:03:19 +00:00
Copy Link
Copy Source

I think the Ember way to set hardcoded object properties is actually Object.freeze() in the normal property definition, as opposed to this way.

I think the Ember way to set hardcoded object properties is actually `Object.freeze()` in the normal property definition, as opposed to this way.
raucao (Migrated from github.com) reviewed 2019-03-27 15:05:55 +00:00
ether_addresses.txt
@@ -0,0 +3,4 @@
0x0020e20e6C9ACc0c9fE78Fcb6a427Ad0cC8aca18 (Parity)
0xD4a64570B12dA659Ee4BBd41c3509B7b1F9c51AC (kosmos parity)
raucao (Migrated from github.com) commented 2019-03-27 15:05:07 +00:00
Copy Link
Copy Source

Is this a personal notes file that was accidentally committed?

Is this a personal notes file that was accidentally committed?
galfert (Migrated from github.com) reviewed 2019-03-27 16:50:36 +00:00
ether_addresses.txt
@@ -0,0 +3,4 @@
0x0020e20e6C9ACc0c9fE78Fcb6a427Ad0cC8aca18 (Parity)
0xD4a64570B12dA659Ee4BBd41c3509B7b1F9c51AC (kosmos parity)
galfert (Migrated from github.com) commented 2019-03-27 16:50:35 +00:00
Copy Link
Copy Source

Damn, yes. This wasn't supposed to be committed.

Damn, yes. This wasn't supposed to be committed.
galfert (Migrated from github.com) reviewed 2019-03-27 16:53:35 +00:00
app/components/chart-contributions-by-type/component.js
@@ -15,0 +17,4 @@
init () {
this._super(...arguments);
this.set('chartOptions', {
galfert (Migrated from github.com) commented 2019-03-27 16:53:34 +00:00
Copy Link
Copy Source

So the chartOptions are not supposed to be changed at any point? Then we can use Object.freeze() instead.

So the `chartOptions` are not supposed to be changed at any point? Then we can use `Object.freeze()` instead.
galfert (Migrated from github.com) reviewed 2019-03-27 17:25:44 +00:00
app/components/chart-contributions-by-type/component.js
@@ -15,0 +17,4 @@
init () {
this._super(...arguments);
this.set('chartOptions', {
galfert (Migrated from github.com) commented 2019-03-27 17:25:44 +00:00
Copy Link
Copy Source

Changed it in the new PR (#89).

Changed it in the new PR (#89).
galfert commented 2019-03-27 17:26:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing in favour of #89, because of an accidentally committed file.

Closing in favour of #89, because of an accidentally committed file.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
This pull request is marked as a work in progress.
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
galfert
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#88